This repository was archived by the owner on Jan 22, 2020. It is now read-only.
Data script tag insertion doesn't use regex#187
Open
jjacobskind wants to merge 1 commit intopaypal:masterfrom
Open
Data script tag insertion doesn't use regex#187jjacobskind wants to merge 1 commit intopaypal:masterfrom
jjacobskind wants to merge 1 commit intopaypal:masterfrom
Conversation
Contributor
|
@jjacobskind what are your thoughts on adding some more tests around this? |
Author
|
You mean just testing that special regex characters no longer cause an error? I can do that. |
Contributor
|
yes please |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I was getting an invalid checksum error when rendering a page that contained a series of dollar signs ($$$). Since dollar signs are a special character in regex, every two dollar signs were being combined into a single escaped dollar sign (ex: $$$ -> $$).